Await provider.send in sender worker#577
Open
Dobrunia wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the sender worker to await all provider.send() calls so that task completion (and downstream RabbitMQ acking) only occurs after notification delivery has finished, allowing send failures to propagate and be retried by the worker mechanism.
Changes:
- Added
awaitto previously fire-and-forgetthis.provider.send(...)calls in the sender worker task handlers. - Added a regression test ensuring
handle()rejects whenprovider.send()rejects.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| workers/sender/src/index.ts | Ensures task handlers await provider.send() so failures propagate and completion reflects actual delivery outcome. |
| workers/sender/tests/worker.test.ts | Adds coverage that handle() rejects if provider.send() fails (verifies the new awaiting behavior). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
neSpecc
approved these changes
Jul 14, 2026
slaveeks
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Await all
provider.send()calls so RabbitMQ messages are acked only after delivery finishes, and send failures can be retried/stashed.